Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username and no password #88

Closed
ge-lem opened this issue Nov 16, 2021 · 1 comment
Closed

Username and no password #88

ge-lem opened this issue Nov 16, 2021 · 1 comment

Comments

@ge-lem
Copy link
Contributor

ge-lem commented Nov 16, 2021

This condition did'nt work when username is set and password is None. Password can be optional. It is in paho-mqtt.

https://github.com/sbtinstruments/asyncio-mqtt/blob/5d8a0f1dbdee35e3def307587176ec896abc2848/asyncio_mqtt/client.py#L151

I was stuck half an hour to undertand this library needed password="" to work. Otherwise the username is not set and you get a connection refused.

@frederikaalund
Copy link
Collaborator

Hi Shikoruma, thanks for opening this issue. Let me have a look. :)

Good catch! 👍 Indeed, paho allows you to set the username and leave the password blank. This doesn't currently work in asyncio-mqtt. You already found the culprit and it looks like it's an easy fix. Do you want to submit a pull request? :)

ge-lem added a commit to ge-lem/asyncio-mqtt that referenced this issue Nov 17, 2021
password is optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants