Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass arguments to underlying client's connect method. #56

Merged
merged 2 commits into from
Mar 28, 2021
Merged

Add ability to pass arguments to underlying client's connect method. #56

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f65425f
Add ability to pass arguments to backing client's connect method.
yawor Mar 27, 2021
8ce3f2a
Include connect args in Client constructor
yawor Mar 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion asyncio_mqtt/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
cast,
)


try:
from contextlib import asynccontextmanager
except ImportError:
from async_generator import asynccontextmanager # type: ignore

import paho.mqtt.client as mqtt # type: ignore
from paho.mqtt.properties import Properties

from .error import MqttCodeError, MqttConnectError, MqttError
from .types import PayloadType, T
Expand Down Expand Up @@ -80,9 +82,19 @@ def __init__(
will: Optional[Will] = None,
clean_session: Optional[bool] = None,
transport: str = "tcp",
keepalive: int = 60,
bind_address: str = "",
bind_port: int = 0,
clean_start: bool = mqtt.MQTT_CLEAN_START_FIRST_ONLY,
properties: Optional[Properties] = None,
):
self._hostname = hostname
self._port = port
self._keepalive = keepalive
self._bind_address = bind_address
self._bind_port = bind_port
self._clean_start = clean_start
self._properties = properties
self._loop = asyncio.get_event_loop()
self._connected: "asyncio.Future[int]" = asyncio.Future()
self._disconnected: "asyncio.Future[Optional[int]]" = asyncio.Future()
Expand Down Expand Up @@ -154,7 +166,9 @@ async def connect(self, *, timeout: int = 10) -> None:
# [3] Run connect() within an executor thread, since it blocks on socket
# connection for up to `keepalive` seconds: https://git.io/Jt5Yc
await loop.run_in_executor(
None, self._client.connect, self._hostname, self._port, 60
None, self._client.connect,
self._hostname, self._port, self._keepalive, self._bind_address, self._bind_port,
self._clean_start, self._properties
)
client_socket = self._client.socket()
_set_client_socket_defaults(client_socket)
Expand Down