fix: remove expected from inputs interface

empirical-run · May 22, 2024 · 9a42b0c · 9a42b0c
1 parent d8e87e4
commit 9a42b0c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 32 deletions.
diff --git a/apps/web/components/sample-output-card.tsx b/apps/web/components/sample-output-card.tsx
@@ -58,18 +58,12 @@ export default function SampleOutputCard({
   const showCompareAgainst = useMemo(
     () =>
       !baseSample?.output.tool_calls?.length &&
-      (baseSample?.expected?.value ||
-        comparisonSamples?.some(
-          (comparisonSample, index) =>
-            comparisonSample?.output &&
-            comparisonResults?.[index]?.id !== baseResult?.id,
-        )),
-    [
-      baseResult?.id,
-      baseSample?.expected?.value,
-      comparisonResults,
-      comparisonSamples,
-    ],
+      comparisonSamples?.some(
+        (comparisonSample, index) =>
+          comparisonSample?.output &&
+          comparisonResults?.[index]?.id !== baseResult?.id,
+      ),
+    [baseResult?.id, comparisonResults, comparisonSamples],
   );
 
   const clearDiffView = useCallback(() => {
@@ -163,21 +157,6 @@ export default function SampleOutputCard({
                         >
                           <span className="text-xs">none</span>
                         </DropdownMenuCheckboxItem>
-                        {baseSample?.expected?.value && (
-                          <DropdownMenuCheckboxItem
-                            checked={
-                              diffView.enabled && diffView.type === "expected"
-                            }
-                            onCheckedChange={() => {
-                              enableDiffView({
-                                type: "expected",
-                                text: baseSample?.expected?.value || "",
-                              });
-                            }}
-                          >
-                            <span className="text-xs">expected</span>
-                          </DropdownMenuCheckboxItem>
-                        )}
                         {comparisonSamples?.map((s, i) => {
                           const result = comparisonResults?.[i];
                           if (result?.id === baseResult.id) {

diff --git a/packages/types/src/index.ts b/packages/types/src/index.ts
@@ -172,7 +172,6 @@ export type DatasetSampleInputs = any;
 export type DatasetSample = {
   id: string;
   inputs: DatasetSampleInputs;
-  expected?: string;
 };
 
 export type Dataset = {
@@ -183,7 +182,6 @@ export type Dataset = {
 export type DatasetSampleConfig = {
   id?: string;
   inputs: DatasetSampleInputs;
-  expected?: string;
 };
 
 export type DatasetConfig =
@@ -215,9 +213,6 @@ export type RunSampleOutput = {
   scores?: Score[];
   inputs: DatasetSampleInputs;
   output: RunOutput;
-  expected?: {
-    value: string;
-  };
   error?: {
     code?: string;
     message: string;