Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(interactivity): add or remove sample rows in the ui #123

Merged
merged 12 commits into from
Apr 15, 2024

Conversation

arjunattam
Copy link
Member

@arjunattam arjunattam commented Apr 12, 2024

Open to dos

  • add new run experience is broken - stuck on loading
  • toast is not working for scenario where user is attempting to remove last sample
  • sample row is added at the end of the ui (not after the current sample)
  • (zero sample playground) current implementation only works when one sample exists (from dataset config) and a new one is added
  • show "run button" when the sample is edited (not just when outputs are empty)
  • test on all examples to cover all scenarios
  • add change set

Copy link

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: 4380bc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
web Minor
@empiricalrun/types Patch
@empiricalrun/cli Patch
@empiricalrun/core Patch
@empiricalrun/scorer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arjunattam arjunattam changed the title [wip] feat: add or remove sample rows in the ui feat(interactivity): add or remove sample rows in the ui Apr 13, 2024
@arjunattam arjunattam marked this pull request as ready for review April 13, 2024 09:37
saikatmitra91
saikatmitra91 previously approved these changes Apr 15, 2024
@@ -95,6 +100,16 @@ export default function Page(): JSX.Element {
[activeRun, removeRun],
);

const onClickRunOnAllModelsForSample = useCallback(
(sample: DatasetSample) => {
const runsWithoutSample = runResults.filter(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const runsWithoutSample = runResults.filter(
const runsWithoutSampleOutput = runResults.filter(

@saikatmitra91 saikatmitra91 merged commit 8ffc64e into main Apr 15, 2024
2 checks passed
@saikatmitra91 saikatmitra91 deleted the add-sample branch April 15, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants