feat: add support for parameters in gemini models #137
Conversation
KaustubhKumar05
commented
Apr 16, 2024
•
KaustubhKumar05
commented
- use startChat conditionally since it is not supported by gemini-1.5-pro
🦋 Changeset detectedLatest commit: b858f80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }); | ||
| return ( | ||
| isBetaModel | ||
| ? modelInstance.generateContent({ contents }) |
There was a problem hiding this comment.
should we do a spread on model parameters for the generateContent call as well?
given the code is a bit hairy, this could use a test that just ensures we never regress on scenarios. setting up the test is easy (since we have a few examples now). but will need additional config on the CI to set the environment variable for GOOGLE_API_KEY. will leave it up to you whether you want to add the test - not a blocker
There was a problem hiding this comment.
Would be better to have the test. Will update this today. Missed the notifications earlier
There was a problem hiding this comment.
cool, call me if you need help in setting up test + CI
There was a problem hiding this comment.
Added the tests, will need help adding the API key
Co-authored-by: Arjun Attam <arjunattam@gmail.com>
Empirical Run Summary
Total dataset samples: 2 |
saikatmitra91
changed the title
