Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: python scorer should prefer config.name #67

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix: python scorer should prefer config.name #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55770de
fix: python scorer should prefer config.name
arjunattam Apr 2, 2024
3dcf9cf
chore: changeset
arjunattam Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quick-plants-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@empiricalrun/scorer": patch
---

fix: python script scorer should prefer config.name
6 changes: 3 additions & 3 deletions packages/scorer/src/provider/deterministic/script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const scoreWithPythonScript: ScoringFn = async ({
return [
{
score: 0,
name,
name: config.name || name,
message: "Python script path is not provided for running the scorer",
},
];
Expand Down Expand Up @@ -57,7 +57,7 @@ export const scoreWithPythonScript: ScoringFn = async ({
JSON.stringify([
{
score: 0,
name,
name: config.name || name,
message: "Scorer script timed out",
},
]),
Expand All @@ -79,7 +79,7 @@ export const scoreWithPythonScript: ScoringFn = async ({
JSON.stringify([
{
score: 0,
name,
name: config.name || name,
message: `Scorer script error: ${message}`,
},
]),
Expand Down