Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Editing: Ability to rotate images #88

Open
krissy opened this issue Aug 20, 2016 · 12 comments
Open

Image Editing: Ability to rotate images #88

krissy opened this issue Aug 20, 2016 · 12 comments
Assignees

Comments

@krissy
Copy link
Member

krissy commented Aug 20, 2016

What

Allow the user to rotate images on upload/edit and add interaction buttons

How

  • Implement rotation functionality with our existing file management gem Paperclip - We can add some rough link/s to trigger the rotation on the frontend so you're not blocked by UI decisions
  • Design and implement an Image Editing UI (inline buttons vs modal?)

Considerations

Liase with team on Slack re UI

@krissy krissy added this to the Post-Pilot (update me) milestone Aug 20, 2016
@krissy krissy changed the title Ability to rotate images IMAGE EDITING: Ability to rotate images Aug 20, 2016
@krissy krissy changed the title IMAGE EDITING: Ability to rotate images Image Editing: Ability to rotate images Aug 20, 2016
@rocioleon rocioleon self-assigned this Sep 22, 2016
@rocioleon
Copy link

rocioleon commented Sep 27, 2016

The solution is based on the research about Ephox TextBoox.io and Wix.com edit image features. There are attached a wireframe to be reviewed.

ephox_research_

https://www.ephox.com/blog/from-the-ux-desk-road-testing-inline-image-editing/

@rocioleon
Copy link

Here is a link to see the TextBox.io documentation in case this is helpful
http://docs.ephox.com/display/tbio/Getting+Started

@rocioleon
Copy link

After feedback, here is the amended wireframe for desktop. The idea is after having selected the file, the user can click on the thumbnail to open the edit popup module to rotate, and crop(rotate or the image. Then apply changes or cancel to close the popup.
in-line_image_editing-1024px 5
in-line_image_editing-1024px_popup 6

@rocioleon
Copy link

This is the version for the phone device
in-line_image_editing-320px 7

@rocioleon
Copy link

Any feedback or question...

@marizoldi
Copy link

What if we placed the crop/rotate/ok functions in a small rounded menu that is an overlay onthe image (currently I put it on the right side). The cancel function can be just clicking outside the overlay box. I have made an example below.

I have used Material icons which are free and super helpful for dev too: https://design.google.com/icons

They inlcude this rotate and crop function which I think is useful to add to the menu ..

crop-rotate-01
crop-rotate-02

@rocioleon
Copy link

Thanks! Let's talk about it.

@CathMollie
Copy link
Collaborator

CathMollie commented Oct 6, 2016

Both of these ideas are good. We could A/B test them maybe - with our existing piloters in Serbia or with our EH community?
@rocioleon what do you think?

@tanyapowell
Copy link
Member

@rocioleon for the mobile version, would a user still have to double click on an image to get the image editing options to appear in the overlay?
Also, is it worth having a button so there is a clear CTA instead of having a label saying (Double click on image to edit)? So that it's really really obvious that option is available?

@krissy
Copy link
Member Author

krissy commented Mar 11, 2017

@CathMollie @rocioleon @EChesters @tanyapowell @marizoldi Who owns the UX decisions for this ticket and #89? Now we're moving towards HDX dataset integration we need to prioritise the quality of our data, so ability to rotate (then crop secondary) could now become a priority, at least for Super Admins to start for post-editing. Should we resume convo?

@CathMollie
Copy link
Collaborator

Cath comments on Slack, 16 March:

@rocioleon
Copy link

Working on this week as wireframe needs to be amend + Google Material design suggested by @marizoldi + Upload New Drawing Form design by @EChesters
Then,
-#89 will be updated accordingly @EChesters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants