V3 #85
Open
V3 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgirault
force-pushed
the
v3
branch
2 times, most recently
from
e8025d6
to
8ceb717
Compare
|
Hello, |
|
Hi, |
felixgirault
force-pushed
the
v3
branch
4 times, most recently
from
48b3072
to
0b4c213
Compare
felixgirault
force-pushed
the
v3
branch
3 times, most recently
from
b5d6f9a
to
dc28fdd
Compare
* preact * react-modal
Another option would have been to make every class name fully configurable (the whole class name instead of just the prefix), but the cost of it would outweigh the gain. Also, the `stylePrefix` option wasn't even documented, so we're betting on the fact that very few people are actually using it, if any.
This change is to better align with CNIL's recommendations. For now, the change has been made kind of brutally, so some things don't make sense (i.e. purposes can have purposes...). Further changes will fix the remaining problems.
This seems to be the most broadly used naming.
For now, they are just set to empty strings, but this allows to see what's missing at a glance.
The previous mechanics were overly complicated for such a small app, and pretty unlegible.
This pages allow one to migrate a config from v2 to v3 to ease the transition.
Particularly, "Content Management Platform" was missing, despite being the common name for such an app.
Typings provided by the module were breaking the build because of type errors. We're using a much simpler version that just covers our use case, while being typesafe.
Dynamic imports were not typed correctly, so there were no type checks on imported code usage.
When loading, the modal would always be showned, regardless of the configuration. Now the UI is properly loaded, showing components only when needed. It is still possible to open the modal directly with `prompt()` (previously `show()`), as it was originally intended.
When the modal is forced open on startup, this message should only be shown if the purposes were updated since the last visit.
Using Empreinte Digitale's new visual identity.
Mainly with preact and its compat layer.
react-modal was way too heavy for the needs of Orejime. Switching to micromodal takes the uncompressed UI bundles from ~110ko to ~60ko.
Using swc cuts down the execution time by a factor of 10.
This allows using the lib within a bundler, while still providing an autoloading mechanism for standard usage. Translations are migrated from yaml to ts to simplify the build and import process, as there is no real advantage to using yaml here. The preloading mechanism is removed, as there is a 99% chance that the UI will be shown on a first visit.
Using tsup simplifies and speeds up the process.
`tsup` was generating a custom type for each and every translation object, with all of their properties, resulting in a huge declaration. It turns out that `satisfies` does not impact the output, whereas `as` forces the `Translation` type to be used. We're still keeping the `satisfies` part, as it provides better typechecking (i.e. warning about missing or unknown properties).
* Folded the annotated configuration by default * Added details on theming
* fixed page markup * added missing styles * added a section in the doc
When running a dev server, renaming chunks doesn't work as expected.
HTML elements require dataset props to be camelCased.
When using React 18+, the app must be rendered using createRoot.
Events added by micromodal weren't properly unregistered, causing errors after closing a modal. Also, hiding the banner with `display: none` was preventing focus to be moved back to it after closing the modal.
* harmonized color names * fixed issues when closing modals by clicking the backdrop * fixed focus issue on toggle buttons (using `aria-disabled` instead of `disabled` prevents losing focus when the state changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.