Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin to be composed of little broccoli plugins. #32

Merged
merged 25 commits into from
Jan 8, 2020

Conversation

billybonks
Copy link
Contributor

@billybonks billybonks commented Jul 22, 2019

Index.js now behaves like a stream configurator instead of a plugin that did all the things. we need a major bump since I deleted the deprecated code.

What are the gains?

  1. Less processing since we don't process markdown files over and over again.
  2. Better composability we could now drop in replace a ToC or a serializer.

What are the tradeoffs

I probably do a bit more IO, I could have done less but chose a cleaner solution, with a strong composability API

here is something I found while looking for in-memory options. broccolijs/broccoli#355.

Next steps

we can open up new API options.
need to do a bit more discussion around toc, (serialization is coupled with construction).
should we move the plugins out of the repo?

@billybonks billybonks requested a review from mansona January 8, 2020 14:15
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am supper happy with this work and I'm really looking forward to pushing the merge button 🎉

@mansona mansona merged commit cc8f60d into master Jan 8, 2020
@mansona mansona deleted the refactor/smaller-broccoli-plugins branch January 8, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants