Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desktop): add id for tree node #1776

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix(desktop): add id for tree node #1776

merged 4 commits into from
Oct 16, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Oct 16, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

image

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #1244

What is the new behavior?

  1. Fixed duplicate key values.
  2. In topic tree data, the label of a node is not absolutely unique. Add an id attribute.

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request fix Fix bug or issues desktop MQTTX Desktop labels Oct 16, 2024
@ysfscream ysfscream added this to the v1.11.0 milestone Oct 16, 2024
@ysfscream ysfscream requested a review from Red-Asuka October 16, 2024 03:11
@ysfscream ysfscream self-assigned this Oct 16, 2024
src/views/viewer/TopicTree.vue Outdated Show resolved Hide resolved
@Red-Asuka Red-Asuka merged commit 4fa0841 into main Oct 16, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/desktop branch October 16, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants