Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): implement CLI installation feature #1842

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

Red-Asuka
Copy link
Member

PR Checklist

What is the new behavior?

  • MQTTX Web now displays an option to install the CLI. Clicking it redirects to the CLI download page.
  • Replaced axios with fetch.
  • Fixed the sudoInstall method, converting sudo.exec from a callback-based to a Promise-based implementation.
  • Optimized code logic by removing unnecessary events and parameters.
  • Enhanced type-checking to improve code maintainability.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka added refactor Refactor code or architecture web MQTTX Web desktop MQTTX Desktop labels Dec 19, 2024
@Red-Asuka Red-Asuka added this to the v2.0.0-alpha.1 milestone Dec 19, 2024
@Red-Asuka Red-Asuka self-assigned this Dec 19, 2024
@Red-Asuka Red-Asuka requested a review from ysfscream December 19, 2024 09:33
@Red-Asuka Red-Asuka marked this pull request as ready for review December 19, 2024 09:34
@ysfscream ysfscream merged commit 995db8c into dev/2.0.0 Dec 20, 2024
5 checks passed
@ysfscream ysfscream deleted the lyd/2.0.0 branch December 20, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop refactor Refactor code or architecture web MQTTX Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants