Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(desktop): add electron-context-menu #1864

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat(desktop): add electron-context-menu #1864

merged 2 commits into from
Jan 21, 2025

Conversation

Red-Asuka
Copy link
Member

@Red-Asuka Red-Asuka commented Jan 20, 2025

PR Checklist

What is the current behavior?

There is no built-in context menu in Electron.

What is the new behavior?

  • Supports common context menu features, such as spell check, text options like Cut / Copy / Paste, and link options like Copy Link. Additionally, in development mode, an Inspect Element menu item is added for quickly viewing items in the inspector, similar to Chrome.
  • Supports i18n for the context menu.
  • Added store communication events to facilitate sharing simple data between the main process and renderer process.
image

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@Red-Asuka Red-Asuka requested a review from ysfscream January 20, 2025 08:58
@Red-Asuka Red-Asuka self-assigned this Jan 20, 2025
@Red-Asuka Red-Asuka added feature This pr is a feature refactor Refactor code or architecture desktop MQTTX Desktop labels Jan 20, 2025
@Red-Asuka Red-Asuka added this to the v2.0.0-alpha.1 milestone Jan 20, 2025
@Red-Asuka Red-Asuka marked this pull request as ready for review January 20, 2025 08:59
@ysfscream ysfscream merged commit c82fb43 into dev/2.0.0 Jan 21, 2025
5 checks passed
@ysfscream ysfscream deleted the lyd/2.0.0 branch January 21, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop feature This pr is a feature refactor Refactor code or architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants