-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #259 from emqx/fix-default-integer-not-from-string
fix: builtin type don't convert from_string when value is integer
- Loading branch information
Showing
4 changed files
with
131 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| %%-------------------------------------------------------------------- | ||
| %% Copyright (c) 2021-2023 EMQ Technologies Co., Ltd. All Rights Reserved. | ||
| %% | ||
| %% Licensed under the Apache License, Version 2.0 (the "License"); | ||
| %% you may not use this file except in compliance with the License. | ||
| %% You may obtain a copy of the License at | ||
| %% | ||
| %% http://www.apache.org/licenses/LICENSE-2.0 | ||
| %% | ||
| %% Unless required by applicable law or agreed to in writing, software | ||
| %% distributed under the License is distributed on an "AS IS" BASIS, | ||
| %% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| %% See the License for the specific language governing permissions and | ||
| %% limitations under the License. | ||
| %%-------------------------------------------------------------------- | ||
| -module(hocon_schema_builtin_tests). | ||
|
|
||
| -include_lib("typerefl/include/types.hrl"). | ||
| -include_lib("eunit/include/eunit.hrl"). | ||
| -include("hocon_private.hrl"). | ||
| -include("hoconsc.hrl"). | ||
|
|
||
| -export([roots/0, fields/1, to_ip_port/1]). | ||
|
|
||
| -type ip_port() :: tuple() | integer(). | ||
|
|
||
| -typerefl_from_string({ip_port/0, ?MODULE, to_ip_port}). | ||
| -reflect_type([ip_port/0]). | ||
|
|
||
| roots() -> | ||
| [listener]. | ||
|
|
||
| fields(listener) -> | ||
| [{"bind", hoconsc:mk(ip_port(), #{default => 80})}]. | ||
|
|
||
| builtin_check_test() -> | ||
| Conf = "listener.bind = 1024", | ||
| ?assertEqual(#{<<"listener">> => #{<<"bind">> => 1024}}, check_plain(Conf)), | ||
| Conf1 = "listener.bind = 0", | ||
| ?assertEqual(#{<<"listener">> => #{<<"bind">> => 0}}, check_plain(Conf1)), | ||
| Conf2 = "listener.bind = 65535", | ||
| ?assertEqual(#{<<"listener">> => #{<<"bind">> => 65535}}, check_plain(Conf2)), | ||
| BadConf1 = "listener.bind = 65536", | ||
| ?assertThrow( | ||
| #{ | ||
| exception := "port_number_too_large", | ||
| field := <<"bind">>, | ||
| path := "listener", | ||
| reason := failed_to_check_field | ||
| }, | ||
| check_plain(BadConf1) | ||
| ), | ||
| BadConf2 = "listener.bind = -1", | ||
| ?assertThrow( | ||
| #{ | ||
| exception := "port_number_must_be_positive", | ||
| field := <<"bind">>, | ||
| path := "listener", | ||
| reason := failed_to_check_field | ||
| }, | ||
| check_plain(BadConf2) | ||
| ), | ||
| BadConf3 = "listener.bind = 1883d", | ||
| ?assertThrow( | ||
| #{ | ||
| exception := "bad_port_number", | ||
| field := <<"bind">>, | ||
| path := "listener", | ||
| reason := failed_to_check_field | ||
| }, | ||
| check_plain(BadConf3) | ||
| ), | ||
| ok. | ||
|
|
||
| check_plain(Str) -> | ||
| {ok, Map} = hocon:binary(Str, #{}), | ||
| hocon_tconf:check_plain(?MODULE, Map, #{}). | ||
|
|
||
| to_ip_port(Str) -> | ||
| case split_ip_port(Str) of | ||
| {"", Port} -> | ||
| %% this is a local address | ||
| {ok, parse_port(Port)}; | ||
| {MaybeIp, Port} -> | ||
| PortVal = parse_port(Port), | ||
| case inet:parse_address(MaybeIp) of | ||
| {ok, IpTuple} -> | ||
| {ok, {IpTuple, PortVal}}; | ||
| _ -> | ||
| {error, bad_ip_port} | ||
| end; | ||
| _ -> | ||
| {error, bad_ip_port} | ||
| end. | ||
|
|
||
| split_ip_port(Str0) -> | ||
| Str = re:replace(Str0, " ", "", [{return, list}, global]), | ||
| case lists:split(string:rchr(Str, $:), Str) of | ||
| %% no colon | ||
| {[], Str} -> | ||
| {"", Str}; | ||
| {IpPlusColon, PortString} -> | ||
| IpStr0 = lists:droplast(IpPlusColon), | ||
| case IpStr0 of | ||
| %% drop head/tail brackets | ||
| [$[ | S] -> | ||
| case lists:last(S) of | ||
| $] -> {lists:droplast(S), PortString}; | ||
| _ -> error | ||
| end; | ||
| _ -> | ||
| {IpStr0, PortString} | ||
| end | ||
| end. | ||
|
|
||
| parse_port(Port) -> | ||
| case string:to_integer(string:strip(Port)) of | ||
| {P, ""} when P < 0 -> throw("port_number_must_be_positive"); | ||
| {P, ""} when P > 65535 -> throw("port_number_too_large"); | ||
| {P, ""} -> P; | ||
| _ -> throw("bad_port_number") | ||
| end. |