-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aauth v3.0.0 #151
Comments
Raphael - I think this sounds like a good plan. Please let me know where I can help. TIM |
thx tim, nice to know that you want to help 😄 english is not my native language you could check the docs when they are ready/finished 😃 |
I'll certainly do some testing :) |
Default/self testing are not really needed with v3.0.0 😃
i started writing v3.0.0 as Test-driven development. |
Test's don't always catch bugs :D |
well but almost all :P |
it is very good. I will also code a simple control panel to arrange users and permissions from web gui. |
I have made good progress this week with v3.0.0. I tested it with PHPunit 4.8 on PHP5.5 and PHPunit 5.4 with PHP5.6 & 7.0, @emreakay thats a point in my plans too
|
The user model could have magic getters mapped to the user variables. It would be very convenient to use such code:
Magic |
Magic functions are better use in library, not use in Controller-Model construction, or you will meet many problems. You can try put __get() in Controller then you will know what I mean. |
@neilsf Don't think wrong but you wouldn't use the models. You would still use the library, the models are only for database actions that are used by the library. @terrylinooo I thought the same thing 😃 it's more a enhancement for the library than for the model. I considered to make create_user "magic" too, like this |
@terrylinooo |
Hey guys I'm making good progress with v3,
What you think about this? P.S.: I'll update the CodeCoverage & Docs next weekend. |
Looks good. Was going to ask for an update earlier :D |
the group_to_subgroup change makes a lot of sense. The other three are probably personal preference, but I have no objections. On Jun 30, 2016, at 2:07 PM, Raphael Jackstadt notifications@github.com wrote: Hey guys I'm making good progress with v3, user_to_group => group_to_user P.S.: I'll update the CodeCoverage & Docs next weekend. — |
Guys sry for the lack of updates i will update the codecoverage & docs later in the day |
When is the estimated release date for Aauth 3 though ? I am kind of afraid to pick up Aauth 2 because it might become a problem when migrating/upgrading to Aauth 3 since CI2 will no longer be supported. |
CI2 is no longer supported by its developers, so you should look to migrate to CI3. It's pretty easy to do and means you are fully up to date! |
There is no estimated release date at the moment, but Aauth v3 will be easy to migration from v2. From the CI Download page:
|
i thin in previews version there was no relation between users and user_variables tables. anyway i done this relation manually. |
@pars0097 which version you mean? |
@REJack |
I've never heard about this problem, if you look into the code in L932 there you see it delete user's perms, groups, variables & the user it self. |
yes you right. $this->aauth_db->where('user_id', $user_id); anyway this problem just happen when use phpmyadmin to delete a user. |
Oh ok, but i dont think that we can implement that because we going to use a automatic database initialization class with CI's DB Forge and there is no way to set the relation between this 2 tables, maybe it comes with CI4 😄 |
remove hash_password() |
Correct. The old password hashing method is not really secure 😃. |
@REJack |
@nimrod-cohen yes |
when will you release v3 exactly? |
At the moment i know no exact release date, i hope end of this year. |
I have another suggestion for v3. Add foreign key constraints to the database tables. |
nice idea, i added it to the list 😄 |
Nice! Another suggestion: remove (or significantly increase) the default max number for passwords. There is absolutely no reason to limit the password lengths. The single greatest security variable in passwords are length. And perhaps increase the minimum as well. |
I have that already in my head the whole config file defaults will be changed 😄 i change it anytime i use Aauth in a project. My personal settings are max 32 & min 8, i would use these for the v3 defaults. |
Why such a low number as 32? Let users go bonkers, set it at 256. (A bit of interesting Saturday reading: https://blog.codinghorror.com/your-password-is-too-damn-short/ ) |
Idk how much max chars bcrypt allows and how long the result is for the db, We can add also multiple config file like a minimal security, default security & maximum security 😃 |
I'll keep posting suggestions for v3 here now that I'm working with Aauth a bit. A user should be able to log in using email and username, there is no reason to restrict it to one. If you feel the need to restrict you can add a config option. |
nice idea, but i dont know right now how to handle this as "the" only way or a simple config option 😄 I am add this to the list. |
Just leave my comment here to show how much I appreciate your awesome work and I'm very excited to hear your upgrading to Aauth 3. PS: You should post your work on CodeIgniter forum, or even better, make an official site and add donation method so at least I can buy you a drink or two. |
Thanks @AzrielOmega, it's not only my work, I am only a contributor 😄 I'll talk with @emreakay about CI Forum thread, Official Site & Donations. |
Hi everyone Sorry for this massive delay with v3 state updates, I had a lot of work. I created a Project on GitHub for v3 with the actual state of my work,
P.S.: I'll push tomorrow the last version of 2.5 (in my opinion) with this changes/enhancements:
|
Hi Guys, i was busy with my Job but i created a fork for v3 and published the state of my work plus Travis-CI for testing and Coveralls CodeCoverage publishing. I've removed the Waffle.io badge from README.md in my fork, because i use GitHub's Project feature here. regards REJack |
thank , i check |
@REJack i want to contribute by writing french documentation base on engish one. |
@steflight how you mean "something like a REST version", like a controller for codeigniter-restserver or something else? |
@REJack sorry for my silence ; yes i'm talking about something like codeigniter restserver |
@steflight do you know if there is any better alternative to codeigniter-restserver? I've never used a REST in CI 😄 |
ok @REJack i will try to set up it like a REST API |
I'll close this issue, it's a new v3 news there (#191). regards REJack |
Hi Guys,
i'm planning to start with v3.0.0 of Aauth,
the first Version without support for CodeIgniter 2.x
My plans are:
sprintf
overall Aauth would need PHP 5.5 or higher
If anyone has some suggestions, feel free to answer on this issue 😃.
EDIT/ADDITIONAL:
config, language, libraries & models
-folders + the docs as PDFvendor
-folder, downloaded/integrated composer(there some website hosts they not give a ability for a SSH access)
vendor
-folder, not integrated composer decencies.editorconfig
EditorConfig helps to define and maintain consistent coding styles between different editors and IDEs,The text was updated successfully, but these errors were encountered: