Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Add llvm.minnum.f(32|64) and llvm.maxnum.f(32|64) intrinsics #210

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

varkor
Copy link
Contributor

@varkor varkor commented Dec 23, 2017

The corresponding change to Emscripten is this PR:
emscripten-core/emscripten#5978, and relates to this
issue: emscripten-core/emscripten#5976. I’m using
#143 as a model.

@kripken
Copy link
Member

kripken commented Dec 28, 2017

Thanks!

The maxnum ones seem to have already existed, on line 700. We can remove the duplication by removing the old ones, I think, your additions are simpler.

The corresponding change to Emscripten is this PR:
emscripten-core/emscripten#5978, and relates to this
issue: emscripten-core/emscripten#5976. I’m using
emscripten-core#143 as a model.
@varkor varkor force-pushed the minnum-maxnum-intrinsics branch from d3096f7 to 09e1f76 Compare December 28, 2017 10:26
@varkor
Copy link
Contributor Author

varkor commented Dec 28, 2017

Ah, forgot to check for maxnum independently of minnum! Fixed that now.

@kripken kripken merged commit 71a2e4b into emscripten-core:incoming Jan 5, 2018
@varkor varkor deleted the minnum-maxnum-intrinsics branch January 5, 2018 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants