Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About async method in library_webgpu.js #20668

Closed
xdestiny110 opened this issue Nov 9, 2023 · 3 comments
Closed

About async method in library_webgpu.js #20668

xdestiny110 opened this issue Nov 9, 2023 · 3 comments
Assignees
Labels

Comments

@xdestiny110
Copy link
Contributor

I noticed that several async methods in WebGPU, including wgpuDeviceCreateRenderPipelineAsync and wgpuShaderModuleGetCompilationInfo, have not been implemented yet. Do you have a timeline or plan for their implementation? If there are plans for implementing these functions, I am willing to contribute code.

@kainino0x
Copy link
Collaborator

I totally forgot we hadn't implemented wgpuDeviceCreate{Compute,Render}PipelineAsync. We're going to be refactoring all of the async code soonish, so I won't plan to implement them now. But if these methods are useful to you then I'd be happy to accept a contribution!

@xdestiny110
Copy link
Contributor Author

@kainino0x I'm glad to hear that things will be refactored! I have some of the methods implemented already and I'd like to submit a PR.
BTW, I observed significant changes in webgpu_native, such as removing swapchain and moving related functionality into surface. How will the synchronization in this regard be approached?

@kainino0x
Copy link
Collaborator

BTW, I observed significant changes in webgpu_native, such as removing swapchain and moving related functionality into surface. How will the synchronization in this regard be approached?

The changes in webgpu-native/webgpu-headers#203 are modeled after what wgpu has, so it would be best to look at their documentation. Maybe here https://docs.rs/wgpu/latest/wgpu/type.SurfaceConfiguration.html#structfield.present_mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants