swapchain & presentation rework #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
force-pushed
the
surface-rework
branch
from
9e34065 to
7f211e8
Compare
Kangz
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
LGTM though I'd like @kainino0x to look at it as well.
It's going to be a pain to update Dawn ^^
kainino0x
approved these changes
Aug 2, 2023
rajveermalviya
force-pushed
the
surface-rework
branch
from
7f211e8 to
1717a23
Compare
This was referenced Aug 3, 2023
rajveermalviya
force-pushed
the
surface-rework
branch
2 times, most recently
from
30fb8eb to
2249667
Compare
rajveermalviya
force-pushed
the
surface-rework
branch
from
2249667 to
a76cd0f
Compare
kainino0x
approved these changes
Aug 4, 2023
|
Going to go ahead and land this; whoever ends up doing the next Dawn->webgpu-headers update (probably @lokokung) you'll probably want to put this into our generator (tagged "upstream") to preserve these. It'll move them around, but that's fine. |
This was referenced Aug 19, 2023
dj2
added a commit
to dj2/webgpu-headers
that referenced
this pull request
Aug 21, 2023
The TextureUsage is a Bitmask, update the usage in SurfaceConfiguration to use the Flags typedef to be consistent with out uses of TextureUsage. Follow-up to webgpu-native#203
kainino0x
pushed a commit
that referenced
this pull request
Aug 21, 2023
The TextureUsage is a Bitmask, update the usage in SurfaceConfiguration to use the Flags typedef to be consistent with out uses of TextureUsage. Follow-up to #203
ArthurSonzogni
pushed a commit
to ArthurSonzogni/dawn
that referenced
this pull request
Aug 22, 2023
This CL syncs dawn.json to the changes added in webgpu-native/webgpu-headers#203 and other minor differences to upstream webgpu.h. Change-Id: I214a74325e405a3165dbf92b2f455b78377b81b3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/147581 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Dan Sinclair <dsinclair@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
This was referenced Nov 9, 2023
This was referenced May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #197