Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting DeviceLost in various functions and callbacks #209

Closed
kainino0x opened this issue Aug 3, 2023 · 4 comments
Closed

Reporting DeviceLost in various functions and callbacks #209

kainino0x opened this issue Aug 3, 2023 · 4 comments
Labels
async Asynchronous operations and callbacks errors Error reporting has resolution Issue is resolved, just needs to be done

Comments

@kainino0x
Copy link
Collaborator

kainino0x commented Aug 3, 2023 •
edited
Loading

Currently we report DeviceLost in the following places aside from just the DeviceLost callback - places where the JS API does not report it:

The JS API specifies generally that async operations pretend to work successfully after the device is lost (except for MapAsync): gpuweb/gpuweb#1629 (comment)

Should we keep these DeviceLost enum values or should we do more like what the JS API does and pretend everything worked? Notably WASM can only do what JS does, so this makes it a native-only return value - but so are many of the others.
@kainino0x kainino0x added async Asynchronous operations and callbacks !discuss Needs discussion (at meeting or online) errors Error reporting labels Aug 3, 2023
@kainino0x kainino0x mentioned this issue Aug 3, 2023
Merged
@Kangz
Copy link
Collaborator

Kangz commented Aug 4, 2023

We should probably match the JS API and pretend things worked.

@kainino0x
Copy link
Collaborator Author

@kainino0x kainino0x mentioned this issue Aug 24, 2023
Closed
@kainino0x kainino0x added has resolution Issue is resolved, just needs to be done and removed !discuss Needs discussion (at meeting or online) labels Aug 24, 2023
@kainino0x
Copy link
Collaborator Author

  • including for MapAsync, return Unknown?

This changes to Aborted because that's what the upstream JS API does now.

@kainino0x kainino0x mentioned this issue Nov 9, 2024
Merged
kainino0x added a commit to kainino0x/webgpu-headers that referenced this issue Nov 9, 2024
@kainino0x
Remove DeviceLost status from WGPUSurfaceGetCurrentTextureStatus
4a0be26 
We didn't discuss which status we would use for this but "Lost" makes
sense.

Issue webgpu-native#209
@kainino0x kainino0x mentioned this issue Nov 9, 2024
Merged
@kainino0x
Copy link
Collaborator Author

This was done in #396 and #397.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async Asynchronous operations and callbacks errors Error reporting has resolution Issue is resolved, just needs to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kangz @kainino0x