Enable reporting of undefined symbols in wasm-ld #10350
Conversation
sbc100
force-pushed
the
linker_error_on_missing_symbol
branch
2 times, most recently
from
eac7ad2 to
0995dee
Compare
| emscripten_asm_const_double: function() {}, | ||
| emscripten_asm_const_int_sync_on_main_thread: function() {}, | ||
| emscripten_asm_const_double_sync_on_main_thread: function() {}, | ||
| emscripten_asm_const_async_on_main_thread: function() {}, |
There was a problem hiding this comment.
why is this needed, and why just these functions?
There was a problem hiding this comment.
Without this change the list of functions in forwarded_json['Functions']['libraryFunctions'] won't include these since (I suppose) it sees them as data rather than functions?
We need the list of include these functions otherwise this new flag won't work with any EM_ASM-using code.
The comment above here says misc definitions to avoid unnecessary unresolved symbols from fastcomp. Which I guess means that fastcomp undefined symbol checker also depends on these, but that is does't care if they are functions of non-functions. I will update the command and apply this change to all those other ones too.
sbc100
force-pushed
the
linker_error_on_missing_symbol
branch
from
0995dee to
8dcb54d
Compare
|
Should be good to go now. |
When enabled, wasm-ld will report more detailed information about the undefined symbols such as which object file/funcion required the symbols. This works by generating the list of all possible JS-defined symbols and passing that list of wasm-ld so it can determine which symbols are permitted to be undefined. The cost of this feature is that we run the js compiler twice, once before wasm-ld and once after the link once wasm-emscripten-finalize has been run. On my machine this takes around 700 so I'm not enabling this by default yet.
sbc100
force-pushed
the
linker_error_on_missing_symbol
branch
from
236c5a8 to
77acb02
Compare
When enabled, wasm-ld will report more detailed information about the
undefined symbols such as which object file/funcion required the
symbols.
This works by generating the list of all possible JS-defined symbols
and passing that list of wasm-ld so it can determine which symbols
are permitted to be undefined.
The cost of this feature is that we run the js compiler twice, once
before wasm-ld and once after the link once wasm-emscripten-finalize
has been run. On my machine this takes around 700 so I'm not enabling
this by default yet.