STANDALONE_WASM: separate crt1 for commands and reactors #11167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
May 15, 2020
| @@ -160,7 +160,7 @@ var LibraryManager = { | |||
| } | |||
|
|
|||
| if (BOOTSTRAPPING_STRUCT_INFO) { | |||
| libraries = ['library_formatString.js']; | |||
| libraries = ['library_formatString.js', 'library_stack_trace.js']; | |||
There was a problem hiding this comment.
This change makes it way easier to debug issues with gen_struct_info.. without this calls to aboit() end up with stack overload due to missing stackTrace.
kripken
approved these changes
May 18, 2020
Unlike without STANDALONE_WASM users are expected to either define a main or explicitly opt out. This change and paves to way to moving to llvm's new main mangling method: https://reviews.llvm.org/D70700 Fixes: #9640
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike without STANDALONE_WASM users are expected to either define
a main or explicitly opt out.
This change and paves to way to moving to llvm's new main mangling
method: https://reviews.llvm.org/D70700
See: #9640