Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLFW respect GLFW_NO_API flag #12907

Merged

Conversation

bfierz
Copy link
Contributor

@bfierz bfierz commented Nov 28, 2020

In order to support the combined use of GLFW and WebGPU, GLFW should not assign anything to the Emscripten modules context variable. GLFW supports not creating any OpenGL context using the windows attribute GLFW_CLIENT_API.

@welcome
Copy link

welcome bot commented Nov 28, 2020

Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bfierz bfierz force-pushed the feature/glfw-respect-no-client-api-flag branch from e7db924 to 8a3de69 Compare December 1, 2020 19:52
@bfierz bfierz requested a review from kripken December 3, 2020 15:25
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Let me know if you need help with the CI errors.

@bfierz bfierz force-pushed the feature/glfw-respect-no-client-api-flag branch from 8a3de69 to dfce118 Compare December 5, 2020 13:35
@bfierz
Copy link
Contributor Author

bfierz commented Dec 5, 2020

Perfect. Thank you.
I've rebased to the latest master, which resolved all CI issues (previous version was based on 2.0.9).

@kripken kripken merged commit f263265 into emscripten-core:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants