Use a clean environment when building harfbuzz #13995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
sbc100
approved these changes
Apr 24, 2021
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Nice! Thanks for tracking that down.
Contributor
Author
|
Is this good to merge or do you think the failing tests are related to my change? |
Collaborator
|
Failing tests look unrelated but if you could rebase that would make it obvious. |
Prevent CMake from picking up the parent project CFLAGS. Fixes: emscripten-core/emsdk#796
Contributor
Author
|
All green 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent CMake from picking up the parent project CFLAGS.
Fixes: emscripten-core/emsdk#796