Deprecate RUNTIME_LINKED_LIBS setting. NFC
#14004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its better to simply list dynamic library dependencies directly on the command line. Handle the deprecated option by simply added the list of libraries to the command line. This means we no longer need to modify the dylink section after linking since the linker will inject all the needed dynamic libraries that it sees on the command line.
sbc100
force-pushed
the
deprecate_runtime_linked_libs
branch
from
61c194c to
c25daa4
Compare
dschuff
approved these changes
Apr 26, 2021
|
|
||
| Current Trunk | ||
| ------------- | ||
| - The `RUNTIME_LINKED_LIBS` setting is now deprecated. It's better to simply |
There was a problem hiding this comment.
Do we have any examples or documentation of the new CLI UI?
There was a problem hiding this comment.
We have the same amount of documentation for the new method as the old method AFAICT :) .. which is basically none.
Joking aside we should add some yes.
| key, value = s.split('=', 1) | ||
| settings_map[key] = value | ||
|
|
||
| # Libraries are searched before settings_changes are applied, so apply the |
There was a problem hiding this comment.
Is this still true? it looks like there's some library-related code in between the old and new location of this code?
There was a problem hiding this comment.
Hmm .. this comment seem very old yes. Goes back to 9b727e8. I will investigate, but land this as-is if thats ok?
There was a problem hiding this comment.
Yeah, the code doesn't look to me like it should actually depend on what's in between.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 28, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 28, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 28, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 28, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 28, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 28, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 29, 2025
We have had this marked as deprecated since emscripten-core#14004 (more than 4 years).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its better to simply list dynamic library dependencies directly on the
command line.
Handle the deprecated option by simply added the list of libraries to
the command line. This means we no longer need to modify the dylink
section after linking since the linker will inject all the needed
dynamic libraries that it sees on the command line.
The emcc.py change here involves moving the settings parsing code
to before
Find input filesso that we can handle the legacy use ofRUNTIME_LINKED_LIBS by simply adding to
newargsbefore inputfiles are searched for.