Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple one-entry-per-line file format for specifying symbol lists #14170

Merged
merged 2 commits into from
May 17, 2021

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 12, 2021

For options such as EXPORTED_FUNCTIONS that take lists we now support
a simple file format that is just one line per symbol. It doesn't
require any escaping or punctuation.

This is much easier to use and maintain and is in line with other compiler
toolchain options used by gcc and ld. For example ld's
--retain-symbols-file=filename or wasm-ld's
--undefined-file=filename.

This should be especially useful for options like ASYNCIFY_ADD or
ASYNCIFY_REMOVE which often involve a lot of quoting (because they
include things like spaces and commas).

@sbc100 sbc100 force-pushed the simple_response_file branch 7 times, most recently from b40c741 to 8b4ad19 Compare May 12, 2021 22:37
@sbc100 sbc100 requested review from RReverser and kripken May 12, 2021 22:38
docs/emcc.txt Outdated Show resolved Hide resolved
site/source/docs/tools_reference/emcc.rst Outdated Show resolved Hide resolved
ChangeLog.md Show resolved Hide resolved
tests/test_other.py Show resolved Hide resolved
@sbc100 sbc100 force-pushed the simple_response_file branch from 8b4ad19 to 2d2eec2 Compare May 13, 2021 20:27
@sbc100 sbc100 enabled auto-merge (squash) May 13, 2021 20:28
For options such as `EXPORTED_FUNCTIONS` that take lists we now support
a simple file format that is just one line per symbol.   It doesn't
require any escaping or punctuation.

This is much easier to use maintain and is in line with other compiler
toolchain options used by gcc and ld.  For example ld's
`--retain-symbols-file=filename` or wasm-ld's
`--undefined-file=filename`.

This should be especially useful for options like `ASYNCIFY_ADD` or
`ASYNCIFY_REMOVE` which often involvea lot of quoting (because they
include things like spaces and commas).
@sbc100 sbc100 force-pushed the simple_response_file branch from 2d2eec2 to 1e56a39 Compare May 13, 2021 20:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sbc100
Copy link
Collaborator Author

sbc100 commented May 17, 2021

Did you add commits there? (just a rebase?)

@sbc100 sbc100 merged commit 0023740 into main May 17, 2021
@sbc100 sbc100 deleted the simple_response_file branch May 17, 2021 20:40
@kripken
Copy link
Member

kripken commented May 17, 2021

(yes, I happened to see you had automerge, and that it no longer merged cleanly due to a 1-line issue. so I fixed it for automerge's benefit, as otherwise I think you might not get a ping from github?)

@sbc100
Copy link
Collaborator Author

sbc100 commented May 17, 2021

Sweet.. happy for you to fix to and land my PRs any time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants