Handle empty listen sockets gracefully. #16472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``accept()`` syscall no longer crashes with error message ``TypeError: Cannot read property 'stream' of undefined`` when sockfs has no pending listen socket. The syscall now returns ``EINVAL`` on error. See: emscripten-core#16047 Signed-off-by: Christian Heimes <christian@python.org>
sbc100
reviewed
Mar 11, 2022
I don't have spare time to write a reproducer in C. Let's keep the ticket open and we can look into the issue later. The changeset turns the crash into a recoverable error in CPython's test suite. It's a small progress. |
sbc100
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accept()syscall no longer crashes with error messageTypeError: Cannot read property 'stream' of undefinedwhen sockfshas no pending listen socket. The syscall now returns
EINVALonerror.
See: #16047
Signed-off-by: Christian Heimes christian@python.org