-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back in __gxx_personality_v0 #17222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aheejin what do you think?
I don't think I support adding a random symbol that does nothing just because rust happens to expect it to exist.
However it has been shown IIRC, that at least at the bitcode level clang does generate references to this symbol (that then get removed later).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking good!
I think having a dummy symbol is fine, as long as we document it well what it's for and it is meant to be a temporary measure.
Clang generates that only because Rust library has that symbol, so I think it's better to remove it from the Rust side eventually. |
Just to be clear this is already done: |
@hoodmane Yeah, I wasn't clear. I mean, it would be good if it can be eventually removed from all supported Rust versions 😅 |
See discussion here:
rust-lang/rust#98030
I removed rust's reference to this function
rust-lang/rust#97888
but this hasn't been released yet and it would be helpful to support slightly older versions of rust for a while if it's as easy as leaving this stub function.