Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in __gxx_personality_v0 #17222

Merged
merged 13 commits into from
Jun 16, 2022

Conversation

hoodmane
Copy link
Collaborator

See discussion here:
rust-lang/rust#98030

I removed rust's reference to this function
rust-lang/rust#97888
but this hasn't been released yet and it would be helpful to support slightly older versions of rust for a while if it's as easy as leaving this stub function.

tests/test_core.py Outdated Show resolved Hide resolved
@kripken kripken requested a review from sbc100 June 15, 2022 16:35
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aheejin what do you think?

I don't think I support adding a random symbol that does nothing just because rust happens to expect it to exist.

However it has been shown IIRC, that at least at the bitcode level clang does generate references to this symbol (that then get removed later).

src/library.js Outdated Show resolved Hide resolved
tests/test_core.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good!

tests/test_other.py Outdated Show resolved Hide resolved
system/lib/libcxxabi/src/gxx_personality_stub.cpp Outdated Show resolved Hide resolved
tests/test_other.py Outdated Show resolved Hide resolved
@aheejin
Copy link
Member

aheejin commented Jun 15, 2022

@sbc100

@aheejin what do you think?

I think having a dummy symbol is fine, as long as we document it well what it's for and it is meant to be a temporary measure.

However it has been shown IIRC, that at least at the bitcode level clang does generate references to this symbol (that then get removed later).

Clang generates that only because Rust library has that symbol, so I think it's better to remove it from the Rust side eventually.

@hoodmane
Copy link
Collaborator Author

it's better to remove it from the Rust side eventually

Just to be clear this is already done:
rust-lang/rust#97888

@aheejin
Copy link
Member

aheejin commented Jun 15, 2022

@hoodmane Yeah, I wasn't clear. I mean, it would be good if it can be eventually removed from all supported Rust versions 😅

system/lib/libcxxabi/src/cxa_exception_emscripten.cpp Outdated Show resolved Hide resolved
tests/test_other.py Outdated Show resolved Hide resolved
tools/system_libs.py Outdated Show resolved Hide resolved
tests/test_other.py Outdated Show resolved Hide resolved
@sbc100 sbc100 enabled auto-merge (squash) June 16, 2022 00:37
@sbc100 sbc100 merged commit 28020ed into emscripten-core:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants