-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports: upgrade sdl2 to 2.24.2 #18026
Conversation
Hey, SDL 2.24.2 has been released, this should upgrade the port for it. It fixes an important bug in the emscripten build for SDL 2.24.0 and 2.24.1. |
Looks good to me assuming tests pass. I'm not sure why circleci is having issue with this PR.. it doesn't want to run at all. Can you perhaps log into circleci? In theory you should not need an account there, but in practice we have seen that sometimes it helps. |
Some more possible CircleCI issues documented here: https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization- |
Thanks @sbc100 ! I logged in and after setting up the emscripten project in my fork, I force pushed and then it worked! Edit: actually I can't seem to be able to run build-linux, which blocks all tests........
|
Seems reasonable. (I really need to remember to keep this up-to-date...) |
@kripken hey, is there a procedure to do to make it run in Emscripten account instead of mine? |
That's very strange, I thought that's exactly what it does all the time? We constantly get people opening PRs and it always runs CI using our account to pay for it. Opening a PR here should do that. Can you cc me in that discussion, if that's not what they are saying? Maybe there's more context for what "building under your fork" means in that quote. |
Thanks, sent you the email :) |
Thanks, I got the cc. If they don't offer a solution in a day or so we can try some more things like merging in latest main to here - it's possible doing that on an existing PR will work. |
I have to say I don't understand the CircleCI people's last suggestion, something about unfollowing your fork and then following the upstream one..? Anyhow, I opened a branch that pulled this in, and got a CI run here: One unrelated error that looks like a flake, so I think this is good to land! |
Thanks, I was trying to figure out the CircleCI UI at lunch time but decided to try again later. Thank you for the merge! |
SDL 2.24.2 is released!