Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports: upgrade sdl2 to 2.24.2 #18026

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Ports: upgrade sdl2 to 2.24.2 #18026

merged 1 commit into from
Nov 9, 2022

Conversation

ericoporto
Copy link
Contributor

@ericoporto ericoporto commented Oct 10, 2022

SDL 2.24.2 is released!

@ericoporto
Copy link
Contributor Author

Hey, SDL 2.24.2 has been released, this should upgrade the port for it. It fixes an important bug in the emscripten build for SDL 2.24.0 and 2.24.1.

@sbc100
Copy link
Collaborator

sbc100 commented Nov 2, 2022

Looks good to me assuming tests pass.

I'm not sure why circleci is having issue with this PR.. it doesn't want to run at all. Can you perhaps log into circleci? In theory you should not need an account there, but in practice we have seen that sometimes it helps.

@kripken
Copy link
Member

kripken commented Nov 2, 2022

@ericoporto
Copy link
Contributor Author

ericoporto commented Nov 2, 2022

Can you perhaps log into circleci?

Thanks @sbc100 ! I logged in and after setting up the emscripten project in my fork, I force pushed and then it worked!

Edit: actually I can't seem to be able to run build-linux, which blocks all tests........

Resource class docker for xlarge is not available for your project, or is not a valid resource class. This message will often appear if the pricing plan for this project does not support docker use.

@sbc100
Copy link
Collaborator

sbc100 commented Nov 2, 2022

@Daft-Freak

@Daft-Freak
Copy link
Collaborator

Seems reasonable.

(I really need to remember to keep this up-to-date...)

@ericoporto
Copy link
Contributor Author

Hello

Thank you for raising a support ticket with CircleCI!

The reason that this is happening is that you are building under your fork of the project.

We have taken a look at your account and we can see that you are on the free plan.

The reason for the failure is that the xlarge resource class is only available for customers on the performance or scale plan as shown on our features page

@kripken hey, is there a procedure to do to make it run in Emscripten account instead of mine?

@kripken
Copy link
Member

kripken commented Nov 7, 2022

That's very strange, I thought that's exactly what it does all the time? We constantly get people opening PRs and it always runs CI using our account to pay for it. Opening a PR here should do that.

Can you cc me in that discussion, if that's not what they are saying? Maybe there's more context for what "building under your fork" means in that quote.

@ericoporto
Copy link
Contributor Author

ericoporto commented Nov 7, 2022

Thanks, sent you the email :)

@kripken
Copy link
Member

kripken commented Nov 7, 2022

Thanks, I got the cc.

If they don't offer a solution in a day or so we can try some more things like merging in latest main to here - it's possible doing that on an existing PR will work.

@kripken
Copy link
Member

kripken commented Nov 9, 2022

I have to say I don't understand the CircleCI people's last suggestion, something about unfollowing your fork and then following the upstream one..? Anyhow, I opened a branch that pulled this in, and got a CI run here:

bbab960

One unrelated error that looks like a flake, so I think this is good to land!

@kripken kripken merged commit b1a4545 into emscripten-core:main Nov 9, 2022
@ericoporto ericoporto deleted the upgrade-sdl2.24.2 branch November 9, 2022 16:51
@ericoporto
Copy link
Contributor Author

Thanks, I was trying to figure out the CircleCI UI at lunch time but decided to try again later. Thank you for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants