Allow commit ce4c405 to roll in #18230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow that commit caused a runtime assertion failure on macOS with Node v14.15.5 (whose active support ended a year ago) when testing `other.test_emcc_output_worker_mjs`. This seems to happen only for the multi-environment build, which could indicate that it fails on the `await import` statement.
|
... perhaps we should wait to see if the same failure occurs on https://chromium-review.googlesource.com/c/emscripten-releases/+/4035147, it could also be a flaky (since it's not reproducible on Linux and Windows with the same Node version). (I currently don't have access to a macOS-based system here) |
kripken
approved these changes
Nov 17, 2022
sbc100
approved these changes
Nov 18, 2022
|
It does look like a flake, as the roll after it passed this test. Perhaps we can land this later if it turns out to be a frequent flake, let's see how things go... |
|
Looks like a flaky test indeed. Not sure if this only occurs on macOS. I'll abandon this PR, will revisit this if it starts to fail more often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow that commit caused a runtime assertion failure on macOS with Node v14.15.5 (whose active support ended a year ago) when testing
other.test_emcc_output_worker_mjs.This seems to happen only for the multi-environment build, which could indicate that it fails on the
await importstatement.Note that I'm not sure why the auto-roller doesn't test this with Node v14.18.2 (which was landed via commit emscripten-core/emsdk@24e7881).