jsifier.js: Move __proxy handling so it happens before wasm64 wrapping
#18707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logically the code make more sense here in processLibraryFunction, but its also important that the wasm64 wrapper is the outermost one. Without this the wasm64 adapter is applied to the inner, non-proxied function only. Split out from #18705
kripken
reviewed
Feb 10, 2023
| }`); | ||
| } | ||
|
|
||
| if (SHARED_MEMORY) { |
There was a problem hiding this comment.
Before this was in a check isFunction while now it isn't I think? That's probably fine as only functions can be proxied. Maybe worth an assertion though?
There was a problem hiding this comment.
This whole code block is now inside of processLibraryFunction which is only ever called on functions.
kripken
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically the code make more sense here in processLibraryFunction, but its also important that the wasm64 wrapper is the outermost one. Without this the wasm64 adapter is applied to the inner, non-proxied function only.
Split out from #18705