Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default minimum Node.js version to 16.0.0 #19192

Merged
merged 13 commits into from
Jun 21, 2023
2 changes: 2 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ See docs/process.md for more on how version tagging works.

3.1.42 (in development)
-----------------------
- Bump the default minimum Node version from 10.19 to 16.0. To target the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default minimum Node version was bumped

Also can you add the word "default" to the PR title?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but isn't "was bumped" passive voice, which is generally frowned upon in English? I guess just "bump" as in the old text isn't even grammatical...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bump the default minimum Node version" sounds correct grammatically but that sounds like that text I would write for the PR itself. i.e. its in the present tense, imperative mood. e.d. "Rename foo", "Delete X"

For the changelog entry I normally write in the past tense think. e.g. "foo was renamed", "x was deleted". So I would expect "was bumped" here... but I could be wrong. Reading the rest of the changelog it seems to be mostly be in the past. Should we swith to using the same tense/mood for PR and for the changelog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Let's go with your intuition here (changelog in the past, PRs in the present).

previous minimum version (10.19.0), use `-sMIN_NODE_VERSION=101900` (#19192).
- The log message that emcc will sometime print (for example when auto-building
system libraries) can now be completely supressed by running with
`EMCC_LOGGING=0`.
Expand Down
2 changes: 1 addition & 1 deletion src/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -1797,7 +1797,7 @@ var MIN_CHROME_VERSION = 75;
// distinct from the minimum version required run the emscripten compiler.
// This version aligns with the current Ubuuntu TLS 20.04 (Focal).
// Version is encoded in MMmmVV, e.g. 1814101 denotes Node 18.14.01.
var MIN_NODE_VERSION = 101900;
var MIN_NODE_VERSION = 160000;

// Tracks whether we are building with errno support enabled. Set to 0
// to disable compiling errno support in altogether. This saves a little
Expand Down