-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default minimum Node.js version to 16.0.0 #19192
Merged
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8ecfab1
Update minimum Node.js version to 15.0.0
kripken 5712fff
Merge remote-tracking branch 'origin/main' into min.node.15
kripken 62af277
changlog [ci skip]
kripken 501f34e
Merge remote-tracking branch 'origin/main' into min.node.15
kripken 3f9591d
16
kripken d95cc1e
update and generalize test
kripken a03ff65
feedback
kripken b1fc768
Merge branch 'main' into min.node.15
kripken 431c208
Merge remote-tracking branch 'origin/main' into min.node.15
kripken 4c2a6e6
Make other.test_node_unhandled_rejection use self.build() so it uses …
kripken bf6fa36
Merge remote-tracking branch 'origin/min.node.15' into min.node.15
kripken b2cb9c7
clarify changelog
kripken fcbb74c
clarify changelog
kripken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default minimum Node version was bumped
Also can you add the word "default" to the PR title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, but isn't "was bumped" passive voice, which is generally frowned upon in English? I guess just "bump" as in the old text isn't even grammatical...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Bump the default minimum Node version" sounds correct grammatically but that sounds like that text I would write for the PR itself. i.e. its in the present tense, imperative mood. e.d. "Rename foo", "Delete X"
For the changelog entry I normally write in the past tense think. e.g. "foo was renamed", "x was deleted". So I would expect "was bumped" here... but I could be wrong. Reading the rest of the changelog it seems to be mostly be in the past. Should we swith to using the same tense/mood for PR and for the changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Let's go with your intuition here (changelog in the past, PRs in the present).