Fix for chatty bat files when path contains spaces #20916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2023
Closed
sbc100
force-pushed
the
fix_bat_files
branch
from
e1a9f1d to
d380a65
Compare
Indeed. Unfortunately Microsoft has abandoned cmd.exe development (even though they could have had several ways to keep improving it in a 100% backwards compatible manner). It seems to be some kind of law of nature that in each OS, either the command line terminal or the file explorer/finder/viewer must suck. Kind of a weird ask in this case, but would you be able to write a unit test for this case in |
sbc100
force-pushed
the
fix_bat_files
branch
7 times, most recently
from
449f57a to
4d3536c
Compare
|
Added test and verified that is fails without this change. |
I have no idea what causes this issue but unless we code the path passed to `@if exist` then the commands within are echoed. This only happens when the path contains spaces, and only for the to commands within the `@if exist`. The endless mystery of cmd.exe. Fixes: emscripten-core#20913
sbc100
force-pushed
the
fix_bat_files
branch
from
4d3536c to
1c5d075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what causes this issue but unless we code the path passed to
@if existthen the commands within are echoed. This only happens when the path contains spaces, and only for the to commands within the@if exist.The endless mystery of cmd.exe.
Fixes: #20913