Skip to content

Remove createDyncallWrapper and its usage #22825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/library.js
Original file line number Diff line number Diff line change
Expand Up @@ -1855,9 +1855,6 @@ addToLibrary({
$dynCalls: '{}',
#endif
$dynCallLegacy__deps: [
#if MAIN_MODULE == 1
'$createDyncallWrapper'
#endif
#if MINIMAL_RUNTIME
'$dynCalls',
#endif
Expand Down Expand Up @@ -1887,11 +1884,6 @@ addToLibrary({
#if MINIMAL_RUNTIME
var f = dynCalls[sig];
#else
#if MAIN_MODULE == 1
if (!('dynCall_' + sig in Module)) {
Module['dynCall_' + sig] = createDyncallWrapper(sig);
}
#endif
var f = Module['dynCall_' + sig];
#endif
return f(ptr, ...args);
Expand Down
154 changes: 0 additions & 154 deletions src/library_makeDynCall.js

This file was deleted.

1 change: 0 additions & 1 deletion src/modules.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export const LibraryManager = {
'library_html5.js',
'library_stack_trace.js',
'library_wasi.js',
'library_makeDynCall.js',
'library_eventloop.js',
'library_promise.js',
];
Expand Down
9 changes: 0 additions & 9 deletions test/test_other.py
Original file line number Diff line number Diff line change
Expand Up @@ -14246,15 +14246,6 @@ def test_warn_once(self):
''')
self.do_runf('main.c', 'warning: foo\ndone\n')

def test_dyncallwrapper(self):
self.set_setting("MAIN_MODULE", 1)
expected = """\
2 7
i: 2 j: 8589934599 f: 3.120000 d: 77.120000
j1: 8589934599, j2: 30064771074, j3: 12884901891
"""
self.do_runf("test_runtime_dyncall_wrapper.c", expected)

def test_compile_with_cache_lock(self):
# Verify that, after warming the cache, running emcc does not require the cache lock.
# Previously we would acquire the lock during sanity checking (even when the check
Expand Down
33 changes: 0 additions & 33 deletions test/test_runtime_dyncall_wrapper.c

This file was deleted.

Loading