Avoid some unneccesary path resolution #23172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a bunch of codepaths where we have a node or a stream and we turn it back into a path, then eventually call `lookupPath` on it to turn it back into a node. This removes a few of these instances.
hoodmane
force-pushed
the
avoid-path-resolution
branch
from
29efaf0 to
44979a6
Compare
sbc100
reviewed
Dec 16, 2024
| @@ -895,6 +896,9 @@ FS.staticInit(); | |||
| FS.readdirNode(FS.lookupPath(path, { follow: true }).node); | |||
| }, | |||
| readdirNode(node) { | |||
| if (!node.parent) { | |||
| return []; | |||
| } | |||
There was a problem hiding this comment.
Any idea what these lines were supposed to be doing?
What does not having a parent mean? Is that only true for the root directory? Why would we want that to mean return the empty list?
There was a problem hiding this comment.
Well, if we've unlinked a directory we want to return empty list or raise ENOENT. By contrast, if the directory exists but is empty we return [".", ".."]. So we need to label the directory node as unlinked somehow when we unlink them. I can add a comment here saying that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of codepaths where we have a node or a stream and we turn it back into a path, then eventually call
lookupPathon it to turn it back into a node. This removes a few of these instances.In general, I think it would be good to avoid
stream.pathin favor ofstream.node, since we eventually will calllookupPath()to get backstream.node.