Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: Ubuntu used is Focal 20.04, not Bionic 18.04 #23173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 16, 2024

Reduce confusion by using the correct Ubuntu release name. Currently, the tag is bionic but the image is focal.

-  bionic:
+  focal:
     docker:
       - image: emscripten/emscripten-ci:focal

https://releases.ubuntu.com

Should upgrading to Jammy 22.04 or Noble 24.04 be considered?


Also, resolve four problems raised by the VS Code extension for CircleCI:
image

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@@ -247,7 +247,7 @@ commands:
# detect flakyness.
condition: ${CIRCLE_PULL_REQUEST}
steps:
set-retry-flaky-tests
- set-retry-flaky-tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the old version not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI flags this as an incorrect data type error which means it could easily stop working in future releases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but they don't show it as a config error. I wonder why not? LGTM to this part either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants