Add deterministic prefix in Library.get_flags() (NFC) #23225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This factors duplicate routines to add deterministic prefix paths out to `Library.get_cflags()`. Suggested in emscripten-core#23222 (comment).
sbc100
reviewed
Dec 19, 2024
tools/system_libs.py
Outdated
| source_dir = utils.path_from_root() | ||
| if self.batch_inputs: | ||
| relative_source_dir = os.path.relpath(source_dir, build_dir) | ||
| cflags += [f'-ffile-prefix-map={relative_source_dir}={DETERMINISITIC_PREFIX}'] |
There was a problem hiding this comment.
Can you make these two lines unconditional and avoid the need for the new self.batch_inputs?
There was a problem hiding this comment.
Do you have any other comments?
dschuff
approved these changes
Dec 19, 2024
sbc100
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors duplicate routines to add deterministic prefix paths out to
Library.get_cflags(). Suggested in#23222 (comment).