Remove launcher scripts from git #23761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_entry_points
branch
from
61493c0 to
08ad6c3
Compare
dschuff
approved these changes
Feb 25, 2025
Collaborator
Author
|
I think I'm going to merge this with the larger change to of moving the entry points to |
sbc100
force-pushed
the
remove_entry_points
branch
from
08ad6c3 to
d49fd9a
Compare
sbc100
referenced
this pull request
Aug 9, 2025
sbc100
force-pushed
the
remove_entry_points
branch
from
d49fd9a to
9df2c85
Compare
RReverser
approved these changes
Aug 11, 2025
sbc100
force-pushed
the
remove_entry_points
branch
3 times, most recently
from
49a5d15 to
1ac0f12
Compare
For a while now we have been mandating that `bootstrap` is run before emscripten can be used. This change removes most of the launcher scripts from git (since we can rely on bootstrap to create them). This helps clean up the top level directory. I've left `emcc` and `em++` launchers in source control. If anyone runs these without first running `bootstrap` it will ask them to first run `bootstrap`.
sbc100
force-pushed
the
remove_entry_points
branch
from
1ac0f12 to
0912451
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Aug 19, 2025
Prior to emscripten-core#23761, when all the launcher script lived in git, our emscripten-release builder was checking out the launchers scripts and bundling them will `-rwxr-xr-x` permissions. Once emscripten-core#23761, and `create_entry_points.py` was used to create them on demand the `x` bit was lost except for the user. Fixes: emscripten-core/emsdk#1583
sbc100
added a commit
that referenced
this pull request
Aug 19, 2025
Prior to #23761, when all the launcher script lived in git, our emscripten-release builder was checking out the launchers scripts and bundling them will `-rwxr-xr-x` permissions. Once #23761, and `create_entry_points.py` was used to create them on demand the `x` bit was lost except for the user. Fixes: emscripten-core/emsdk#1583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while now we have been mandating that bootstrap is run before emscripten can be used. This change removes most of the launcher scripts from git (since we can rely on bootstrap to create them).
This helps clean up the top level directory.
I've left emcc and em++ launchers in source control. If anyone runs these without first running bootstrap it will ask them to first run bootstrap.