Fix unexported symbol check for library symbols exported with EXPORTED_FUNCTIONS #24091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
force-pushed
the
unexportedSymbols
branch
from
6a04cd4 to
c885900
Compare
brendandahl
reviewed
Apr 14, 2025
sbc100
force-pushed
the
unexportedSymbols
branch
2 times, most recently
from
23fa318 to
3f074ee
Compare
…D_FUNCTIONS When reporting See emscripten-core#24086
sbc100
force-pushed
the
unexportedSymbols
branch
from
3f074ee to
8b32851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug meant that library symbol exported via
EXPORTED_FUNCTIONSwere incorrectly being reported as not exported using unexportedRuntimeSymbolSee #24086