[embind] Add pointer policies for creating val objects. #24175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Apr 23, 2025
| }) | ||
| def test_embind_no_raw_pointers(self, filename): | ||
| stderr = self.expect_fail([EMCC, '-lembind', test_file(filename)]) | ||
| self.assertContained('Implicitly binding raw pointers is illegal.', stderr) |
There was a problem hiding this comment.
I'm almost tempted to say you should just write 3 separate tests here (since each one is only two lines), but I'm not sure it makes any difference really.
sbc100
approved these changes
Apr 23, 2025
|
Running some tests in g3 before I land this... |
|
Looked good on g3. Merging. |
Using pointers with val worked inconsistently before where: ``` Foo f; Foo* p = &f; val v1(p); // works fine val v2(&f); // fails ``` The pointer working above was probably a mistake[1] and was caused by TypeID normalizing the types differently than how BindingType does. This patch picks up the work done previously[2] to enforce that types are normalized consistently. In the above example both will now require a pointer policy e.g. `(val v(p, allow_raw_pointers())`. [1]emscripten-core#7292 (comment) [2]https://github.com/yeputons/emscripten/tree/fix-7292-embind-type-normalize
brendandahl
force-pushed
the
embind-canon-type
branch
from
88e234a to
ff021f9
Compare
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jul 29, 2025
After emscripten-core#24175, `val` required a pointer policy when creating a `val` with a pointer. In `val.set(key, value)`, a temporary `val` object is created, but there was no way to set the policy from user code. This patch allows the user to pass in `allow_raw_pointers()` to enable this.
brendandahl
added a commit
that referenced
this pull request
Jul 31, 2025
) After #24175, `val` required a pointer policy when creating a `val` with a pointer. In `val.set(key, value)`, a temporary `val` object is created, but there was no way to set the policy from user code. This patch allows the user to pass in `allow_raw_pointers()` to enable this.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Jul 31, 2025
…w_`. After emscripten-core#24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. I used some C++14/17 tricks to separate the regular arguments and policy arguments.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Aug 27, 2025
…w_`. After emscripten-core#24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. I used some C++14/17 tricks to separate the regular arguments and policy arguments.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Sep 4, 2025
…w_`. After emscripten-core#24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. I used some C++14/17 tricks to separate the regular arguments and policy arguments.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Sep 16, 2025
…w_`. After emscripten-core#24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. I used some C++14/17 tricks to separate the regular arguments and policy arguments.
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Sep 29, 2025
…w_`. After emscripten-core#24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. I used some C++14/17 tricks to separate the regular arguments and policy arguments.
brendandahl
added a commit
that referenced
this pull request
Sep 30, 2025
…24832) After #24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. C++17 is required to separate the regular arguments and policy arguments. For older versions of C++, we don't allow policy arguments and just allow pointers by default (too match old behavior). Fixes #24398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using pointers with val worked inconsistently before where:
The pointer working above was probably a mistake[1] and was caused by TypeID normalizing the types differently than how BindingType does. This patch picks up the work done previously[2] to enforce that types are normalized consistently.
In the above example both will now require a pointer policy e.g.
(val v(p, allow_raw_pointers()).[1]#7292 (comment) [2]https://github.com/yeputons/emscripten/tree/fix-7292-embind-type-normalize