Skip to content

[fetch] Add responseUrl to emscripten_fetch_t #24414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 28, 2025
Merged

[fetch] Add responseUrl to emscripten_fetch_t #24414

merged 17 commits into from
May 28, 2025

Conversation

dipidoo
Copy link
Contributor

@dipidoo dipidoo commented May 27, 2025

during redirect, url should be updated to new redirected url

sbc100
sbc100 reviewed May 27, 2025
View reviewed changes
sbc100
sbc100 approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps its worth documenting this since it is technically a behaviour change.

Perhaps in the changelog and also maybe in ./site/source/docs/api_reference/fetch.rst

sbc100
sbc100 approved these changes May 27, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with comments addressed

sbc100
sbc100 reviewed May 27, 2025
View reviewed changes
@dipidoo dipidoo force-pushed the user/dipidoo/fetch-redirect-url-update branch from 58cc214 to 68c5ec0 Compare May 27, 2025 23:29
@sbc100 sbc100 changed the title updates url if redirected during fetch [fetch] Update url if redirected during fetch May 27, 2025
@sbc100 sbc100 enabled auto-merge (squash) May 27, 2025 23:35
auto-merge was automatically disabled May 28, 2025 02:17

Head branch was pushed to by a user without write access

dipidoo
dipidoo commented May 28, 2025
View reviewed changes
sbc100
sbc100 reviewed May 28, 2025
View reviewed changes
sbc100
sbc100 reviewed May 28, 2025
View reviewed changes
@sbc100
Copy link
Collaborator

sbc100 commented May 28, 2025

Can you update the PR title?

@dipidoo dipidoo changed the title [fetch] Update url if redirected during fetch [fetch] Add responseUrl to emscripten_fetch_t May 28, 2025
sbc100
sbc100 reviewed May 28, 2025
View reviewed changes
sbc100
sbc100 reviewed May 28, 2025
View reviewed changes
@sbc100 sbc100 enabled auto-merge (squash) May 28, 2025 22:02
@sbc100 sbc100 merged commit 05d44b1 into emscripten-core:main May 28, 2025
30 checks passed
kripken added a commit to kripken/emscripten_ that referenced this pull request May 29, 2025
@kripken
Fix indentation error from emscripten-core#24414
efa848c
kripken added a commit that referenced this pull request May 29, 2025
@kripken
Fix indentation error from #24414. NFC (#24433)
1206202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipidoo @sbc100