-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement -ffast-math flag mapping to wasm-opt --fast-math (fixes #21497) #25513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devalgupta404
wants to merge
10
commits into
emscripten-core:main
Choose a base branch
from
devalgupta404:clean-ffast-math-only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+42
−4
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
50e42bd
Implement -ffast-math flag mapping to wasm-opt --fast-math
devalgupta404 89d0298
Update documentation for FAST_MATH setting
devalgupta404 744bc84
Make FAST_MATH an internal setting
devalgupta404 ccbe0a2
Add unit test and black box test for --fast-math flag validation
devalgupta404 e501fc5
Fix linting issues in test files
devalgupta404 eac7d7a
tests: fix ruff lint warnings in fast-math tests
devalgupta404 78d2140
Fix ruff lint warnings in fast-math tests
devalgupta404 36f7385
tests: ruff fixes for blackbox test (rm unused imports, 4-space indents)
devalgupta404 e880d41
Fix FAST_MATH to apply to all wasm-opt invocations
devalgupta404 f1a371d
tests: use -v and -ffast-math; remove obsolete unit test
devalgupta404 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong place for this: it is only sent into the very last binaryen tool invocation, as the comment says. We want to send this to every wasm-opt invocation, perhaps in
run_wasm_opt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about in
get_binaryen_passes
?