Update docs for internal EMSCRIPTEN_VERSION setting. NFC #25664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
emscripten_get_compiler_setting
branch
from
3a38538 to
4f8e3c5
Compare
juj
reviewed
Oct 27, 2025
juj
approved these changes
Oct 27, 2025
I proposed removing this internal setting in emscripten-core#25661 but it turns out it was useful for externally managed JS library files. However, I don't think it should be tested as part of emscripten_get_compiler_setting.c since C/C++ can already get the compiler version using VERSION macros, no need for the runtime check. Indeed I hope we can stop exposing any internal settings to emscripten_get_compiler_setting: emscripten-core#25663
sbc100
force-pushed
the
emscripten_get_compiler_setting
branch
from
4f8e3c5 to
67de53b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I proposed removing this internal setting in #25661 but it turns out it was useful for externally managed JS library files.
However, I don't think it should be tested as part of
emscripten_get_compiler_setting.csince C/C++ can already get the compiler version usingVERSIONmacros. . There should be no need for the runtime checks.Indeed I hope we can stop exposing any internal settings to emscripten_get_compiler_setting: #25663
Also, add test for @juj's specific use case for
EMSCRIPTEN_VERSIONin a JS library file.