Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for llvm.sin.f(32|64) intrinsics #4353

Merged
merged 2 commits into from
May 27, 2016

Conversation

Maher4Ever
Copy link
Contributor

@Maher4Ever Maher4Ever commented May 24, 2016

This adds support for the llvm.sin.f(32|64) intrinsic to Emscripten. More details can be found in the issue #4338. The accompanying change to fastcomp is in pull request emscripten-core/emscripten-fastcomp#143

@kripken
Copy link
Member

kripken commented May 24, 2016

Looks good, thanks.

Please rebase (and then push -f to this branch) to get rid of the merge commit.

Also please add a test. Can grep for the similar functions next to it, in tests/, to find the relevant test that I think you can just add a few lines in, if I remember correctly.

@Maher4Ever Maher4Ever force-pushed the fix_sin_intrinsic branch from bb3a90e to def5b5a Compare May 26, 2016 10:15
@Maher4Ever
Copy link
Contributor Author

Thanks about the rebase tip. It makes the history so much cleaner!

I greped for each of the following strings inside tests/ but found nothing:

  • llvm_log and llvm.log
  • llvm_sqrt and llvm.sqrt
  • llvm_pow and llvm.pow
  • llvm_exp and llvm,exp

Are you aware of a more specific folder or file where I should find the tests?

@kripken
Copy link
Member

kripken commented May 26, 2016

Looks like the relevant tests are in tests/core/test_llvm_intrinsics.in and .out.

@Maher4Ever
Copy link
Contributor Author

Done :)

@kripken kripken merged commit f1ab53a into emscripten-core:incoming May 27, 2016
@kripken
Copy link
Member

kripken commented May 27, 2016

Thanks!

@Maher4Ever Maher4Ever deleted the fix_sin_intrinsic branch May 30, 2016 12:56
varkor added a commit to varkor/emscripten that referenced this pull request Dec 23, 2017
varkor added a commit to varkor/emscripten that referenced this pull request Dec 23, 2017
varkor added a commit to varkor/emscripten that referenced this pull request Dec 28, 2017
varkor added a commit to varkor/emscripten that referenced this pull request Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants