-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for llvm.sin.f(32|64) intrinsics #4353
Add support for llvm.sin.f(32|64) intrinsics #4353
Conversation
Looks good, thanks. Please rebase (and then Also please add a test. Can grep for the similar functions next to it, in |
bb3a90e
to
def5b5a
Compare
Thanks about the rebase tip. It makes the history so much cleaner! I greped for each of the following strings inside
Are you aware of a more specific folder or file where I should find the tests? |
Looks like the relevant tests are in |
Done :) |
Thanks! |
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
This fixes emscripten-core#5976. I’m using emscripten-core#4353 as a model.
This adds support for the llvm.sin.f(32|64) intrinsic to Emscripten. More details can be found in the issue #4338. The accompanying change to fastcomp is in pull request emscripten-core/emscripten-fastcomp#143