Fix for rust .a linking #5777
Merged
Fix for rust .a linking #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l object files (e.g. because the input is a sole .a file, so we want it all); a .a may contain metadata or other stuff we should ignore
|
This is great - I've seen some build systems in the past that add in .txt files to archives or similar to store info about the archive creation process specific to that build system, so ignoring extra files seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't link in invalid object files, even if we are force-including all object files (e.g. because the input is a sole .a file, so we want it all); a .a may contain metadata or other stuff we should ignore.
See #5755 (comment)