Fix all flake8 issues on python 3 #9209
Conversation
| HANGUL_S_COUNT = 19 * 21 * 28 | ||
|
|
||
| try: | ||
| unichr |
There was a problem hiding this comment.
indentation looks wrong here, and below
| try: | ||
| return json.loads(text) | ||
| except: | ||
| except ValueError: |
There was a problem hiding this comment.
Again, how can we be sure this is the only type of exception that can arise here?
There was a problem hiding this comment.
From documentation:
If the data being deserialized is not a valid JSON document, a
JSONDecodeError[subclass ofValueError] will be raised.
This is the only kind of error we want to recover from.
| data[i] = encode_utf8(data[i]) | ||
| return data | ||
| elif isinstance(data, unicode): | ||
| elif isinstance(data, type(u'')): |
There was a problem hiding this comment.
This seems strictly less readable to me.
There was a problem hiding this comment.
Would you prefer:
try:
unicode
except NameError:
unicode = strThere was a problem hiding this comment.
Not really. Just noticing out loud that this compatibility can make the code harder to read.
How would you do this in python3-only code?
There was a problem hiding this comment.
I would have written isinstance(data, str) here. But perhaps a better way is doing isinstance(data, bytes) so bytes gets returned raw, and everything goes through str and then encoded.
|
Checking this on CircleCI is the intention of #8878. |
|
@quantum5 looks like this caused breakage on MacOS, see Looks like the change to |
3 participants
Fix all flake8 issues uncovered by #8878 except the one in #9200.