Fix legalization of i64 return values in JS.legalize_sig. #9855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Nov 18, 2019
tools/shared.py
Outdated
| ret = [sig[0]] | ||
| # a return of i64 is legalized into an i32 (and the high bits are | ||
| # accessible on the side through getTempRet0). | ||
| ret = ['i' if sig[0] == 'j' else sig[0]] |
There was a problem hiding this comment.
I find this more readable:
ret = [sig[0]]
# a return of i64(j) is legalized into an i32(i) (and the high bits are
# accessible on the side through getTempRet0).
if ret == ['j']:
ret = ['i']
There was a problem hiding this comment.
Also, use of ret here is a little confusing. When I was first reading this I assumed it refered to return part of the signature. Maybe result or sig_legalized or sig_out?
There was a problem hiding this comment.
Both good points, thanks.
How about just legal for the legalized signature?
|
lgtm |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…-core#9855) emscripten-core#9810 mostly fixed i64 pointers in MAIN_MODULE, but it turns out that a corner case was a function that is illegal only due to its return value. fixes emscripten-core#9850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9810 mostly fixed i64 pointers in MAIN_MODULE, but it
turns out that a corner case was a function that is illegal
only due to its return value.
fixes #9850