Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image not multiarch #687

Open
rickardp opened this issue Jan 24, 2021 · 3 comments
Open

Docker image not multiarch #687

rickardp opened this issue Jan 24, 2021 · 3 comments

Comments

@rickardp
Copy link

rickardp commented Jan 24, 2021

The docker image published to https://hub.docker.com/r/emscripten/emsdk is built for x86_64 only. While it works through the built-in qemu, it would be more efficient if the image was built as a true multi arch image (specifically, aarch64 is useful for Apple silicon).

@sbc100
Copy link
Collaborator

sbc100 commented Jan 25, 2021

If you would like to submit a patch to make this happen it would be most welcome.

@rickardp
Copy link
Author

rickardp commented Jan 25, 2021

I was looking at it, but there seems to be no aarch64 builds of llvm as part of the manifest. Am I correct in this observation? Because if so that would probably need to be the first thing to fix. I tried naively to build it but I compiling llvm under the builtin qemu takes way too long to fit a GitHub Actions job, so cross compilation is required, I believe. Is there anyone looking into this? Or am I mistaken in how it is set up?
In the mean time I'll set up a little cross compilation project one the side to see how far I get :)

@sbc100
Copy link
Collaborator

sbc100 commented Jan 25, 2021

Ah, yes sorry its more complicated that I had thought. The main problem is that emsdk doesn't have arm64 binaries at all... so there is nothing that we don't have the binaries to populate the docker images.

So this is really more about arm64 support in general. So we would need to fix #547 and/or #671 and/or emscripten-core/emscripten#12695 first before we would have anything useful to package.

akoeplinger pushed a commit to akoeplinger/emsdk that referenced this issue Dec 13, 2024
emscripten-core#687)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240223.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24119.1 -> To Version 9.0.0-alpha.1.24123.3

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240223.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24119.1 -> To Version 9.0.0-alpha.1.24123.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants