-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Intel mac CircleCI configuration #1409
Conversation
@walkingeyerobot will there need to be anything interesting done to bazel because of the architecture switch? |
Looks like the bazel test is failing on arm64 mac. The grep/sed pipeline that tries to set I wonder if the |
So the |
OK, just getting the version info from the file as JSON in Python seemed easier than debugging what was going wrong with grep. PTAL. |
also: do you have any idea why the "test-mac" and "test-bazel-mac" jobs are still showing up on the GH UI as "expected"? I thought I correctly got rid of them everywhere. |
The "expected" list of bots is set in the github branch settings for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the jq
tool would be awesome, but I'm not sure how hard it would be to ensure it is installed on all the bot.
|
I don't expect this to cause any problems for bazel. |
|
@dschuff any idea why all PRs now have this pending test on |
Hm, |
I guess you must be looking at #1405. I think if you push another commit it should work as expected with the new config. Otherwise if we just end up accepting the most recent commit there, we can just bypass the branch protections to land it, so no big deal either way. |
Also switch bazel-mac to the arm64 config.
The CircleCI Intel mac config will be turned down soon.