Update nodejs to v12.18.1 #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It includes an update to v8 7.8
sbc100
approved these changes
Jun 23, 2020
scripts/update_node.py
Outdated
| @@ -45,7 +45,7 @@ | |||
|
|
|||
| upload_url = upload_base + filename | |||
| print('Uploading: ' + upload_url) | |||
| cmd = ['gsutil', 'cp', '-n', filename, upload_url] | |||
| cmd = ['gsutil.py', 'cp', '-n', filename, upload_url] | |||
There was a problem hiding this comment.
My gsutil from google-cloud-sdk is shell script with no extension. Where is yours coming from?
There was a problem hiding this comment.
Oops, that was supposed to be just a local change. gsutil.py is included in depot_tools, so I was just using that.
|
Should be good to land now? |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 1, 2020
Fix wasm32 being broken due to a NodeJS version bump Emscripten's SDK [recently bumped the version of NodeJS they shipped](emscripten-core/emsdk#529), but our Dockerfile for the wasm32 builder hardcoded the version number. This will cause consistent CI failures once the currently cached image is rebuilt (either due to a change or due to the cache expiring). This PR fixes the problem by finding the latest version of NodeJS in the Emscripten SDK and symlinking it to a "latest" directory, which is then added to the `PATH`.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 2, 2020
Fix wasm32 being broken due to a NodeJS version bump Emscripten's SDK [recently bumped the version of NodeJS they shipped](emscripten-core/emsdk#529), but our Dockerfile for the wasm32 builder hardcoded the version number. This will cause consistent CI failures once the currently cached image is rebuilt (either due to a change or due to the cache expiring). This PR fixes the problem by finding the latest version of NodeJS in the Emscripten SDK and symlinking it to a "latest" directory, which is then added to the `PATH`.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 2, 2020
Fix wasm32 being broken due to a NodeJS version bump Emscripten's SDK [recently bumped the version of NodeJS they shipped](emscripten-core/emsdk#529), but our Dockerfile for the wasm32 builder hardcoded the version number. This will cause consistent CI failures once the currently cached image is rebuilt (either due to a change or due to the cache expiring). This PR fixes the problem by finding the latest version of NodeJS in the Emscripten SDK and symlinking it to a "latest" directory, which is then added to the `PATH`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It includes an update to v8 7.8