Update CircleCI to more modern docker image #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
update_linux_image
branch
3 times, most recently
from
d86efa9
to
635bbfe
Compare
sbc100
changed the title
sbc100
force-pushed
the
update_linux_image
branch
from
635bbfe
to
68957e8
Compare
sbc100
force-pushed
the
update_linux_image
branch
from
a9e9623
to
2bfe224
Compare
kripken
approved these changes
Jan 26, 2021
| apt-get update -q | ||
| apt-get install -q -y python3-pip | ||
| - run: sudo mv bazel.gpg /etc/apt/trusted.gpg.d/ | ||
| - run: echo "deb [arch=amd64] https://storage.googleapis.com/bazel-apt stable jdk1.8" | sudo tee /etc/apt/sources.list.d/bazel.list |
There was a problem hiding this comment.
sudo seems odd here... but if it works...
There was a problem hiding this comment.
This is installing a new system-wide settings so it makes sense.
In general I think its better that the admin commands require sudo.. since it means that other are not running as root but a normal user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://circleci.com/developer/images/image/cimg/python