Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDZERO - OSD Init/Menu/Stats Centering #992

Merged
merged 9 commits into from
Mar 27, 2024
Merged

HDZERO - OSD Init/Menu/Stats Centering #992

merged 9 commits into from
Mar 27, 2024

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Mar 22, 2024 •
edited
Loading

  • Text centering for OSD init (logo/etc), OSD CMS Menu's, and OSD Disarm-Statistics.
  • unsure if this is complete, but works for Init, OSD CMS menu and disarm Statistics.
  • tested one Analog and two HDZero.
  • i noticed "Rebooting" and "Erasing Flash" text does not display on HDZero. ☹️ (same as master)
  • may be room for improvement, but much better than master.

Test DVR of this PR and PR 991 merged together. (some improvement committed after these DVR, but still valid for showing)

Everything was too left before:
image
image

after
image
image
image
image

@nerdCopter nerdCopter changed the title HDZERO - OSD Centering HDZERO - OSD Init/Menu/Stats Centering Mar 22, 2024
@nerdCopter nerdCopter added the in-testing-needs-testing needs testing before merge consideration label Mar 23, 2024
@nerdCopter nerdCopter requested a review from Quick-Flash March 23, 2024 18:56
@nerdCopter nerdCopter marked this pull request as ready for review March 23, 2024 20:40
Quick-Flash
Quick-Flash approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@Quick-Flash Quick-Flash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch

@nerdCopter
Copy link
Member Author

tested a second Analog.
looks good.
merging.

@nerdCopter nerdCopter merged commit d743e8e into emuflight:master Mar 27, 2024
6 checks passed
@nerdCopter nerdCopter deleted the 20240322_HDZero_OSD_Centering branch March 27, 2024 18:58
@nerdCopter nerdCopter restored the 20240322_HDZero_OSD_Centering branch June 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quick-Flash Quick-Flash Quick-Flash approved these changes

Assignees
No one assigned
Labels
in-testing-needs-testing needs testing before merge consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nerdCopter @Quick-Flash